conflicts with the way #1184 switches over these tests but there are several benefits, mainly do_send can be deprecated or moved to test-utils but is still available for use in test writing and may make the switchover less work with this option available.
Also, this is a true switchover to quick_send / quick_shield with no temporary functions or confusion.
This PR is intended to be used as a tool to highlight any remaining bugs in zip317 before the feature gate is removed and zip317 is released. All wrong assertions due to zip317 fee changes etc. should be fixed in this PR. however, any actual bug fixes should merge into dev. Feature branchs aiming to fix a bug highlighted by a failing test in this PR should merge into dev. This PR should only be merged into the bug fix branchs temporarily to check the bug has been fixed correctly.
conflicts with the way #1184 switches over these tests but there are several benefits, mainly do_send can be deprecated or moved to test-utils but is still available for use in test writing and may make the switchover less work with this option available. Also, this is a true switchover to quick_send / quick_shield with no temporary functions or confusion.
This PR is intended to be used as a tool to highlight any remaining bugs in zip317 before the feature gate is removed and zip317 is released. All wrong assertions due to zip317 fee changes etc. should be fixed in this PR. however, any actual bug fixes should merge into dev. Feature branchs aiming to fix a bug highlighted by a failing test in this PR should merge into dev. This PR should only be merged into the bug fix branchs temporarily to check the bug has been fixed correctly.
This PR will merge when all tests are passing!