zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption
MIT License
15 stars 19 forks source link

Make shielded balance more private #1195

Closed zancas closed 1 month ago

zancas commented 2 months ago

Continuing review, I am refining the balance checking fns a bit.

Builds on #1194

fluidvanadium commented 2 months ago

agree with Oscarz requested changes, otherwise gtg

zancas commented 1 month ago

I addition to the original changes I changes legacy to concrete as the complement to generic.

zancas commented 1 month ago

Hi @fluidvanadium can you please re-review this?

zancas commented 1 month ago

OK, I have fixed merge conflicts and rerun all tests locally. @fluidvanadium