FIX: zip317 sends from shielded to transparent didn't create outgoing_tx_data due to change no longer containing ciphertext for OVK decryption. "send_to_transparent_and_sapling_maintain_balance" in #1205 now passes (when you remove/fix the wrong fee assertions).
replaces is_outgoing_transaction boolean with a "from foundational truth" call to the new transaction_is_received method after the tx has been decrypted and the transaction record has been created.
the new logic will check for either notes in the wallet that were spent in the transaction or if outgoing_tx_data was created when the OVK successfully decrpyted the outgoing ciphertext to a non-self address. then, it will go ahead and create outgoing_tx_data for transparent outputs sent to other capabilities (not send-to-selfs) as before.
previous places is_outgoing_tx was set true that have been replaced:
notes from the wallet were spent in the tx. although this was checked BEFORE the transaction could be created on the first call to scan_full_tx and it used an inferior total_funds_spent_in method
a transparent note was spent in the tx (decrypt_transaction_to_record_transparent)
FIX: zip317 sends from shielded to transparent didn't create outgoing_tx_data due to change no longer containing ciphertext for OVK decryption. "send_to_transparent_and_sapling_maintain_balance" in #1205 now passes (when you remove/fix the wrong fee assertions).
replaces is_outgoing_transaction boolean with a "from foundational truth" call to the new
transaction_is_receivedmethod after the tx has been decrypted and the transaction record has been created.the new logic will check for either notes in the wallet that were spent in the transaction or if outgoing_tx_data was created when the OVK successfully decrpyted the outgoing ciphertext to a non-self address. then, it will go ahead and create outgoing_tx_data for transparent outputs sent to other capabilities (not send-to-selfs) as before.
previous places is_outgoing_tx was set true that have been replaced:
scan_full_txand it used an inferiortotal_funds_spent_inmethoddecrypt_transaction_to_record_transparent)