zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption
MIT License
15 stars 19 forks source link

Do list txs replacement #1213

Closed Oscar-Pepper closed 2 months ago

Oscar-Pepper commented 2 months ago

the purpose of this PR is to replace do_list_transactions with a stable and more readable alternative. datetime is human readable, fee are included and note can be more easily tracked across txs.

zancas commented 2 months ago

What's the difference between a TransactionSummary and a TransactionRecord? Why have both things?

Oscar-Pepper commented 2 months ago

What's the difference between a TransactionSummary and a TransactionRecord? Why have both things?

The aim of transaction summary is to provide a struct to store a snapshot of the relevent user/consumer facing information at the time of the call. for example a transaction record may have information that clutters up the display to the user and also may calculate its status or fee etc. from foundational truths. the summary shows a snapshot of what we knew about the chain at that point in time but a record can adapt and persist as we gain more knowledge

zancas commented 2 months ago

It passed CI before I merged in dev.