zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption
MIT License
15 stars 19 forks source link

Pending QuickSend Correct Fee TEST #1216

Closed fluidvanadium closed 2 months ago

fluidvanadium commented 2 months ago

Previously, fees were miscalculated before scan. FIXED

Whoohoo! This branch buffs the with_assertions module to make sure everything is right from the initial record, even before scanning the broadcast. Previous incarnations of this branch failed. As recently as Wednesday, the following tests failed:

--- STDERR: libtonode-tests::chain_generics chain_generics::propose_and_broadcast_40_000_to_transparent --- thread 'chain_generics::propose_and_broadcast_40_000_to_transparent' panicked at /home/cupress/ZINGO/libs/pending/zingo-testutils/src/assertions.rs:32:9: assertion left == right failed left: 55000 right: 15000

--- STDERR: libtonode-tests::chain_generics chain_generics::send_shield_cycle --- thread 'chain_generics::send_shield_cycle' panicked at /home/cupress/ZINGO/libs/pending/zingo-testutils/src/assertions.rs:32:9: assertion left == right failed left: 124000 right: 20000

However, merging todayz dev fixed this!

zancas commented 2 months ago

I clicked update branch.