helperize core scan_full_tx logic

zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption

MIT License

15 stars 23 forks source link

helperize core scan_full_tx logic #1242

Closed zancas closed 2 months ago

zancas commented 2 months ago

@AloeareV if you're around I'd appreciate you taking a look at this. It has a significant amount of generic-bound related refactor.

zancas commented 2 months ago

the reason being that we are not gaining anything, but we are introducing bugs and also creating multiple places where similar actions are performed (i.e scanning).

As I have outlined, I disagree about the cost-benefit of splitting the entrypoints up, but I agree that it is best treated as a separate concern (whether or not we eventually do).