pending bug was caused by regular mempool checks and/or calls to scan_full_tx with a confirmed status, as pending status was hard coded.
this PR removes add_pending_note and modifies add_new_note to account for both confirmed and pending so confirmed scans can't set a tx back to pending status.
also adds logic to make sure a pending status cannot override a confirmed one
pending bug was caused by regular mempool checks and/or calls to
scan_full_tx
with aconfirmed
status, aspending
status was hard coded.this PR removes
add_pending_note
and modifiesadd_new_note
to account for both confirmed and pending so confirmed scans can't set a tx back to pending status.also adds logic to make sure a pending status cannot override a confirmed one