unified add pending note with add new note

zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption

MIT License

14 stars 21 forks source link

unified add pending note with add new note #1286

Closed Oscar-Pepper closed 2 months ago

Oscar-Pepper commented 2 months ago

pending bug was caused by regular mempool checks and/or calls to scan_full_tx with a confirmed status, as pending status was hard coded.

this PR removes add_pending_note and modifies add_new_note to account for both confirmed and pending so confirmed scans can't set a tx back to pending status.

also adds logic to make sure a pending status cannot override a confirmed one

zancas commented 2 months ago

I vote we figure out how to add an automated test to this before we merge it.