search

zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption
MIT License
14 stars 21 forks source link

Serious Bug: quickshield does not work properly in PTFM release: bad-txns-inputs-duplicate #1311

Closed AlwaysCompile closed 1 month ago

AlwaysCompile commented 1 month ago

I just tested the PTFM and "quickshield" does NOT work atleast with multi transparent UTXOs. Note, that it works in prior releases (via shield), so it is definitely an issue with this release.

Error Message:

"error": "send Broadcast(\"Error: SendResponse { error_code: -26, error_message: \\"16: bad-txns-inputs-duplicate\\" }\")"

It appears Zingo is attempting to create a transaction that is spending UTXOs multiple times. My guess is quickshield was not tested with multi-address, multi-UTXOs scenerios.

Under what scenerior is bug present?

1) On a completely new restored wallet only using the latest version

2) On an old version wallet upgraded to latest version

3) On an upgraded wallet that has been completely rescanned via "rescan"

4) On an upgraded wallet wallet that has been completely "clear"ed and rescanned

The wallet had multiple transparent addresses with balances (multi-address, multi-UTXO). I am not sure if it exists on a wallet with only a single transparent UTXO or a single address with multiple UTXOs.

Did functionality work in prior versions?

Yes, using the old version and the old "shield" command it was able to shield the balances without issue.

AlwaysCompile commented 1 month ago

I tested this when the wallet only has one "UTXOs" and the same issue occurs. PTFM version cannot shield, but prior versions can.

This seems like a pretty serious bug considering it breaks the entire purpose of the wallet (to have private money)

AlwaysCompile commented 1 month ago

Resolved; This was caused by the lightwalletd server being too old of a version