search

zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption
MIT License
14 stars 21 forks source link

ring 0.17.X upgrade #1318

Open juanky201271 opened 1 month ago

juanky201271 commented 1 month ago

In order to build Zingo-pc for windows arm64 I need to upgrade to ring 0.17.x

I need to upgrade BIP0039 from 0.10.1 to 0.11.0 or 0.12.0 in zcash_primitives (https://github.com/zingolabs/librustzcash.git?tag=always_require_change#ae0d477a).

I don't have a clue if this can be a problem in zingolib.

@idky137 Can you help me with that, I hear you have a lot of experience with dependencies...

zancas commented 3 weeks ago

Hi @AloeareV is this review ready? It is marked draft.

AloeareV commented 3 weeks ago

Hi @AloeareV is this review ready? It is marked draft.

Yes, this is review ready! It currently depends on a librustzcash version by commit hash instead of by tag, https://github.com/zingolabs/librustzcash/pull/25 is the PR with the changed librustzcash.

zancas commented 3 weeks ago

So maybe we should put this behind the LRZ upgrade?

zancas commented 5 days ago

Let's deprioritze this behind the LRZ update.

AloeareV commented 2 days ago

Let's deprioritze this behind the LRZ update.

I don't know what you mean. The LRZ update is functional.

zancas commented 2 days ago

Let's deprioritze this behind the LRZ update.

I don't know what you mean. The LRZ update is functional.

If this PR is not necessary to support ZIP320 in mobile, then let's delay work on it.