search

zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption
MIT License
15 stars 23 forks source link

Add Spacers and Points in zingocli balance command #1464

Closed fluidvanadium closed 4 weeks ago

fluidvanadium commented 1 month ago

Adding a decimal point allows easy estimation of zec per zatoshi.

zancas commented 1 month ago

Is this moving us towards reproducing the vaporizing transaction bug?

zancas commented 1 month ago

It looks like this crate has been downloaded aroun 15_000_000 times:

https://crates.io/crates/num-format

Why don't we us it?

zancas commented 1 month ago

I really like the idea of a more useful/readable zingocli interface. I don't like the idea of writing our own reimplementation of standard logic. Let's use the thing that's "off-the-shelf".

fluidvanadium commented 1 month ago

It looks like this crate has been downloaded aroun 15_000_000 times:

https://crates.io/crates/num-format

Why don't we us it?

the answer is: num-format doesnt specifically make use of the 10,000,000 mark for Satoshis