ZIP 320 manual testing ultimate Issues

zingolabs / zingolib

An API and test-app that exposes zcash functionality for app consumption

MIT License

15 stars 23 forks source link

ZIP 320 manual testing ultimate Issues #1483

Open juanky201271 opened 2 days ago

juanky201271 commented 2 days ago

I can see the refund transparent addresses in the Value Transfers List instead a send-to-self transaction without address.
The transmitted transactions aren't persistent when you close/open the App. (Intermittent behavior).
When the first transaction is confirmed I can see a transparent amount and I can shield it, if I do, the shield transaction is confirmed and the second transmitted transaction disappears.
When the fist transaction is confirmed I can send funds to another address, if I do, the send transaction is confirmed and the second transmitted transaction stays in the history immutable for hours, and finally disappears.

@Edicksonjga Maybe you have more or another issues...

zancas commented 2 days ago

Really nice work!

I'd like to work out a road map where eventually all of these states are scripted in an emulator and asserted to be correct.

I think detox tests might permit that?

@Edicksonjga @juanky201271 @dorianvp

Can we meet to discuss the work that remains to get to that point for our test harness?

zancas commented 2 days ago

I see this as a cross-repo concern.

I believe we need to have automated tests running on an emulated app that verify the state of each of these flows. (In zingo-mobile?)

I believe that these issues should properly be fixed in zingolib.

fluidvanadium commented 2 days ago

i am sure, based on edicksonz results, that 3 and 4 are due to #1437

juanky201271 commented 1 day ago

I see this as a cross-repo concern.

I believe we need to have automated tests running on an emulated app that verify the state of each of these flows. (In zingo-mobile?)

I believe that these issues should properly be fixed in zingolib.

I'm working on e2e test for those flows... in zingo-mobile.

juanky201271 commented 1 hour ago

about the number 1 issue I noticed something interesting... 2 different scenarios:

If you update the App normally and you have your wallet there, when you send to TEX sometimes (maybe always...) you can see the refund address.
If you install the App and restore from seed OR if you run a Rescan with the new version of the App, when you send to TEX you always see the send-to-self transaction and you DO NOT see the refund addresses at all.

I hope this make sense to someone... @zancas @fluidvanadium @AloeareV