zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

In the `cli`. consider calrifying help and/or adding a confirmation for the `clear` command #101

Open dannasessha opened 2 years ago

dannasessha commented 2 years ago

In the cli, help clear outputs

Clear the wallet state, rolling back the wallet to an empty state.
Usage:
clear

This command will clear all notes, utxos and transactions from the wallet, setting up the wallet to be synced from scratch.

This message begins with a sentence I feel is confusing or misleading: the wallet will still have addresses and keys that may have balances associated with them, it just will have "forgotten" all this information by "de-syncing", that is, clearing all the associated-state information learned from the chain.

The second sentence is more clear. We should consider either deleting or clarifying the first sentence.

Also, because this command will require a new re-sync, we should consider adding a confirmation to this command, as suggested in #96 . Users on slow connections or restrictive data plans may be particularly sensitive to such an issue.