zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

The variable name `tx` is used to mean both a zcash `transaction` and a channel `sender` #11

Closed AloeareV closed 2 years ago

AloeareV commented 2 years ago

There are a number of instances of this name overloading being potentially confusing, this the most egregious example I've encountered so far. https://github.com/zingolabs/zecwallet-light-cli/blob/17c72a82b7e8686697bcaad2fdd2b9c9d93edfe3/lib/src/blaze/fetch_full_tx.rs#L89-L94