search

zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

Code Coverage Bug #21

Open zancas opened 2 years ago

zancas commented 2 years ago

I clicked the "full_review" link in the (awesome) code-coverage display (pictured) full_review_bug

and got this URL:

https://app.codecov.io/gh/zingolabs/zecwalletlitelib/compare/4?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr%20comments&utm_term=zingolabs

When I got that URL it mentioned a "rate limit".

AloeareV commented 2 years ago

Hmmm.. THe error I got doesn't mention a rate limit. Rather, it says 

Oops, something went wrong
Changes found in between fae6abf...3b2ef3a (pseudo...base) which prevent comparing this pull request. Check on [Codecov's status](http://status.codecov.io/) or see [our docs](https://docs.codecov.io/) for common support.

Error 400
zancas commented 2 years ago

Things "just work" when you run cargo clean && cargo checkmate && cargo tarpaulin locally?

AloeareV commented 2 years ago

The CI right now is running --skip-clean actually, as the rebuild of all the mostly-unchanged dependencies is the majority of what takes so long.

This coverage bug is an issue with the web interface of codecov, we have coverage data being generated and uploaded, I think codecov is confused by something we've done wrong, or missing coverage on some branch it expects coverage on, or something.

AloeareV commented 2 years ago

The CI failure bug has to do with I think --skip-clean not interacting well with the cache script, because there's something that needs to be cached and isn't, but that's not afaict related to this issue at all.

zancas commented 2 years ago

Looks like good progress so far!