zancas commented 2 years ago

The diff of test_server is wonky.. but i think it's just that git is matching on the wrong else clause!?!

Anywho the point is to move to a more organized cleanup mechanism.

codecov-commenter commented 2 years ago

Codecov Report

Merging #25 (47b443d) into update_deps (8f14441) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 47b443d differs from pull request most recent head f272f3b. Consider uploading reports for the commit f272f3b to get more accurate results

@@             Coverage Diff              @@
##           update_deps      #25   +/-   ##
============================================
  Coverage        64.08%   64.08%           
============================================
  Files               29       29           
  Lines             6448     6448           
============================================
  Hits              4132     4132           
  Misses            2316     2316

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f14441...f272f3b. Read the comment docs.

zancas commented 2 years ago

I haven't done the grunt work of (finding the pattern to-) go through and do the two line replacments yet.

Since we now have a struct around the server... we can start transferring the state with members... and possibly implement teardown as part of the drop implementation? Maybe the tokio runtime will prevent this from working.. I think it's clearly a good idea to use this single implementation of this strictly order logic in all test_server tests.

zancas commented 2 years ago

This failure might have been due to an issue in CI. I intend to push more commits to this branch, hopefully that will run against new-and-improved CI.

zancas commented 2 years ago

update_deps merged

zingolabs / zingolib_original

encapsulate create_test_server in struct to collect related behavior #25

Codecov Report