search

zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

NU5 support; lightwalletd version #36

Closed conradoplg closed 2 years ago

conradoplg commented 2 years ago

I did some tests with the upstream ZecWallet on testnet and run into some issues.

Are you planning to work on that in this fork in the near future? (I can help testing and maybe fixing some of what's required, but I'm not too familiar with the codebase yet).

Also, which version of lightwalletd will you be targetting, upstream or aditya's? I think it's important to document that both here and in https://github.com/zingolabs/zecwallet-lite/

zancas commented 2 years ago

We've forked from Aditya, but we've not directly interacted with that code yet (as far as I know).

My intuition is the upstream will be better supported moving forward, so we'll target it, but I am not well-informed on the differences yet.

We'll prioritize making that clear.

https://github.com/zingolabs/zecwalletlitelib/issues/37 is intended to organize that effort.

AloeareV commented 2 years ago

NU5 support is definitely on our radar. Right now we're mostly focused on maintenance-like tasks: getting through a backlog of stale dependencies, upgrading test coverage so that we're covering code before we start changing it, getting CI and other github infrastructure into order, and other miscellany. NU5 is going to be the first significant functionality upgrade we focus on, barring the unexpected.

conradoplg commented 2 years ago

To be clear, I'm not talking about NU5 features like Orchard or unified addresses, but just to make it work with the current features post-NU5 activation (which doesn't seem to happen, from my testing on testnet)

zancas commented 2 years ago

The next step is for us to reproduce your (clearly documented) bug:

https://github.com/adityapk00/zecwallet-lite/issues/156#issue-1245759918

that'll get us "on the same page". I anticipate that we'll do this within the week.

zancas commented 2 years ago

We've reproduced and we're working on this. We think that when we finish porting zecwalletlitelib to depend on zcash/librustzcash V5 parsing should work.

AloeareV commented 2 years ago

I've got a fix up here: https://github.com/zingolabs/zecwalletlitelib/pull/48.

It's still very much draft code. The test's don't compile yet. However, I've been able to send and receive TAZ.

zancas commented 2 years ago

@AloeareV 's fix now has some (but not all) tests running here:

https://github.com/zingolabs/zecwalletlitelib/pull/53

dannasessha commented 2 years ago

Seems like this issue is now solved, even with the last release. Is that correct @zancas and @AloeareV ?

AloeareV commented 2 years ago

Yes.