search

zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

There are (at least) two available forks of lightwalletd #37

Closed zancas closed 2 years ago

zancas commented 2 years ago

https://github.com/adityapk00/lightwalletd

AND

https://github.com/zcash/lightwalletd

We need to choose one, clearly indicate the choice, and target it exclusively.

zancas commented 2 years ago

This bug report might provide a criteria for choosing between the alternatives: https://github.com/adityapk00/zecwallet-lite/issues/156#issue-1245759918

AloeareV commented 2 years ago

My instinct is to target upstream, without very convincing benefits to using aditya's. It's yet another large codebase to keep up with maintenance of in a language I don't believe any of us are particularly experienced with, which is in my opinion a very large downside, especially given the scale of what we're already trying to get up to speed with.

zancas commented 2 years ago

I tentatively agree... but mostly think we need more evidence/data.

zancas commented 2 years ago

This bugfix seems to argue in favor of the zcash variant:

https://github.com/zcash/lightwalletd/releases/tag/v0.4.11

dannasessha commented 2 years ago

We've moved to zcash's version, though we are still fiddling with which branch should use which dependency branch or commit.

Closing.