zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

Add webpki tls server roots to cert store #43

Closed AloeareV closed 2 years ago

AloeareV commented 2 years ago

Plus some cargo format fixes, it looks like

AloeareV commented 2 years ago

I can't build this locally!

Yeah, I put the old code in expecting it to work.. Turns out, the old interface was

roots.add_server_trust_anchors(&webpki_roots::TLS_SERVER_ROOTS);

But the new interface is

roots.add_server_trust_anchors(
        webpki_roots::TLS_SERVER_ROOTS
            .0
            .iter()
            .map(|anchor_ref| {
                OwnedTrustAnchor::from_subject_spki_name_constraints(
                    anchor_ref.subject,
                    anchor_ref.spki,
                    anchor_ref.name_constraints,
                )
            }),
    );

I wrote that code.. Thought it looked like pretty ugly, went to the examples to find a better way...and the example was identical to what I wrote, lol

codecov-commenter commented 2 years ago

Codecov Report

Merging #43 (cb89180) into dev (e2c7fba) will increase coverage by 0.05%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##              dev      #43      +/-   ##
==========================================
+ Coverage   64.10%   64.16%   +0.05%     
==========================================
  Files          29       29              
  Lines        6453     6455       +2     
==========================================
+ Hits         4137     4142       +5     
+ Misses       2316     2313       -3     
Impacted Files Coverage Δ
lib/src/grpc_connector.rs 80.73% <83.33%> (+1.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2c7fba...cb89180. Read the comment docs.

AloeareV commented 2 years ago

fixes #41 and #42