zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

Add orchard key import/export/production support #66

Closed AloeareV closed 2 years ago

AloeareV commented 2 years ago

Currently we compile with untested (well, technically there's a test, so insufficiently tested is more accurate) support for importing orchard spending keys. No support yet for doing anything with them, generating them, I don't even think you the code that generates them is user-facing yet.

codecov-commenter commented 2 years ago

Codecov Report

Merging #66 (7a163bc) into dev (94fe6b1) will decrease coverage by 0.88%. The diff coverage is 11.53%.

:exclamation: Current head 7a163bc differs from pull request most recent head 4d6b1b0. Consider uploading reports for the commit 4d6b1b0 to get more accurate results

@@            Coverage Diff             @@
##              dev      #66      +/-   ##
==========================================
- Coverage   59.88%   59.00%   -0.89%     
==========================================
  Files          29       30       +1     
  Lines        5263     5367     +104     
==========================================
+ Hits         3152     3167      +15     
- Misses       2111     2200      +89     
Impacted Files Coverage Δ
lib/src/lightwallet.rs 66.94% <0.00%> (-2.69%) :arrow_down:
lib/src/lightwallet/walletokey.rs 0.00% <0.00%> (ø)
lib/src/lightclient.rs 61.93% <16.66%> (-0.69%) :arrow_down:
lib/src/lightwallet/keys.rs 47.72% <23.07%> (-1.97%) :arrow_down:
lib/src/lightclient/lightclient_config.rs 38.12% <33.33%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94fe6b1...4d6b1b0. Read the comment docs.

AloeareV commented 2 years ago

As we are capable of now generating, importing, and exporting orchard keys (we can export but not import orchard viewing keys), I'm marking this ready to merge in keeping with the desire for quick incremental changes.

zancas commented 2 years ago

Superceded by: https://github.com/zingolabs/zecwalletlitelib/pull/74