search

zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

Remove log4rs #68

Closed zancas closed 2 years ago

zancas commented 2 years ago

This PR removes significant functionality, but also a vulnerable dependency. I don't necessarily think it should land, but it might serve as an interesting reference for how to deal with this, and similar situations..

codecov-commenter commented 2 years ago

Codecov Report

Merging #68 (537e519) into dev (94fe6b1) will increase coverage by 0.21%. The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #68      +/-   ##
==========================================
+ Coverage   59.88%   60.10%   +0.21%     
==========================================
  Files          29       29              
  Lines        5263     5244      -19     
==========================================
  Hits         3152     3152              
+ Misses       2111     2092      -19
Impacted Files Coverage Δ
cli/src/lib.rs 0.00% <ø> (ø)
lib/src/lightclient.rs 62.94% <ø> (+0.33%) :arrow_up:
lib/src/lightclient/lightclient_config.rs 41.77% <ø> (+3.40%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94fe6b1...537e519. Read the comment docs.

zancas commented 2 years ago

Interesting thought experiment, we need a better logging solution.