search

zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

House keeping #72

Closed zancas closed 2 years ago

zancas commented 2 years ago

This PR begins rebranding. zingowallet-cli is not depended on by any of our other projects and is a good candidate for the first thing to have its name changed.

Note one of the removed dependencies had a "critical" vuln in it. However I don't know if unused dependencies are even compiled? Regardless, having it gone from cli feels nice.

Some deps were... it turns out, unused! I removed the ones I found. I used a tool called udeps to find two in the lib/Cargo.toml... I manually checked each dep in the cli.. the udep tool didn't notice that two in the cli were unused.

codecov-commenter commented 2 years ago

Codecov Report

Merging #72 (df6acba) into dev (94fe6b1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #72   +/-   ##
=======================================
  Coverage   59.88%   59.88%           
=======================================
  Files          29       29           
  Lines        5263     5263           
=======================================
  Hits         3152     3152           
  Misses       2111     2111
Impacted Files Coverage Δ
cli/src/main.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94fe6b1...df6acba. Read the comment docs.