zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

our dependencies of `librustzcash` are behind their `main` branch #79

Open dannasessha opened 2 years ago

dannasessha commented 2 years ago

The dependencies we use in this repo from zcash/librustzcash are behind their main branch. At this moment it's about a dozen commits behind.

dannasessha commented 2 years ago

The latest commit at https://github.com/zcash/librustzcash/commits/main isn't passing tests, but it's "just" a codecov metric.

Also, I got error: build failed after updating the dependency to the most recent comment and trying to run cargo test.

dannasessha commented 2 years ago

Here is the error message

error[E0004]: non-exhaustive patterns: `Unified(_)` not covered
    --> lib/src/lightwallet.rs:1306:35
     |
1306 |             if let Err(e) = match to {
     |                                   ^^ pattern `Unified(_)` not covered
     |
    ::: /home/ha/.cargo/git/checkouts/librustzcash-0a74bd38a00f78b0/3f5ba8d/zcash_client_backend/src/address.rs:148:5
     |
148  |     Unified(UnifiedAddress),
     |     ------- not covered
     |
     = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
     = note: the matched value is of type `RecipientAddress`
zancas commented 2 years ago

Nice!