zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

Consider if in the `cli`, the command `shield` is superfluous. #90

Open dannasessha opened 2 years ago

dannasessha commented 2 years ago

Currently, the README states

* Will automatically shield your transparent funds at the first opportunity
* When sending an outgoing transaction to a shielded address, Zecwallet-CLI can decide to use the transaction to additionally shield your transparent funds (i.e., send your transparent funds to your own shielded address in the same transaction)

Additionally the cli application provides a shield command, which makes a transaction specifically to shield t address balances. This command seems to be essentially just like a send command to one's own z address, including transaction fees and so on.

While typing shield is easier than send <zaddr> <any amount> (at which time the application will send all t address balances to a z address in the same wallet anyway) it may be considered that this command is in no other way an improvement.

Is it possible having this command is superfluous, and we should include a simple description in the README of how one would shield their balances without using this command?