search

zingolabs / zingolib_original

ZingoLib
MIT License
1 stars 1 forks source link

Consider adding a confirmation to the `export` and `seed` commands in the `cli` #96

Open dannasessha opened 2 years ago

dannasessha commented 2 years ago

In the cli, the export command prints all addresses, private keys and viewing keys to the terminal.

While this isn't an error, I think we should consider adding a simple confirmation to this command, as a user might be surprised by the amount of potentially sensitive information all output at once.

A confirmation message might be something like: This command will print all addresses, private keys and viewing keys to this terminal instance. Confirm? [y/N] And should default to 'no'.

dannasessha commented 2 years ago

This also might be relevant to the seed command, which is essentially like printing all the keys as well.