examples: refactoring the flutter_bloc example

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.

https://zino-hofmann.github.io/graphql-flutter

MIT License

3.25k stars 620 forks source link

examples: refactoring the flutter_bloc example #1024

Closed vincenzopalazzo closed 2 years ago

vincenzopalazzo commented 2 years ago

With this PR I would like to discuss if we want remove the flutter block example also because the repo graphql_flutter_bloc is updated also with an example https://github.com/artflutter/graphql_flutter_bloc

So, I don't like to make double work, maybe I could migrate my pokemon app https://vincenzopalazzo.gitlab.io/showwcaseflutterchallenge/ to make a new demo?

Fixes https://github.com/zino-hofmann/graphql-flutter/issues/997

Any comment is welcome

budde377 commented 2 years ago

I think it makes sense to remove the bloc example if we want to support graphql_flutter_bloc as the recommended way to do bloc. I'm not a huge expert on this myself, so I'll take your word for it. In that case, we should make sure that the README is linking to this, and maybe consider doing the same for graphql_codegen for which I'm naturally biased.

vincenzopalazzo commented 2 years ago

I agree, so we will proceed as follows:

Remove the flutter_bloc, and introduce another one like my example
Add in the readme a section that points to a good external package like graphql_flutter_bloc and graphql_codegen
We could also discuss the possibility to make the graphql_codegen a default option for the user, I'm sure that all the users are more than happy to remove the query from the dart string.