Closed budde377 closed 2 years ago
Merging #1041 (5510511) into beta (bea716d) will increase coverage by
0.03%
. The diff coverage is65.00%
.
@@ Coverage Diff @@
## beta #1041 +/- ##
==========================================
+ Coverage 53.93% 53.96% +0.03%
==========================================
Files 40 41 +1
Lines 1511 1512 +1
==========================================
+ Hits 815 816 +1
Misses 696 696
Impacted Files | Coverage Δ | |
---|---|---|
packages/graphql/lib/src/utilities/response.dart | 50.00% <50.00%> (ø) |
|
...ackages/graphql/lib/src/core/observable_query.dart | 41.73% <100.00%> (+1.40%) |
:arrow_up: |
packages/graphql/lib/src/core/query_manager.dart | 69.73% <100.00%> (+1.28%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2cd0727...5510511. Read the comment docs.
Let's add a test illustrating this.
Maybe we open an issue to remember it?
With the introduction of
parserFn
we can annotate parsed type on theQueryResult
. When rebroadcasting, the generic is lost which causes the error:This means that cache updates won't propagate.
This PR refactors the code to preserve type information.
TODO