search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.25k stars 621 forks source link

fix: subscription broadcast #1045

Closed budde377 closed 2 years ago

budde377 commented 2 years ago

Subscriptions aren't rebroadcasted! This PR fixes this and adds a test.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1045 (2f1b98f) into beta (2306e12) will increase coverage by 2.32%. The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #1045      +/-   ##
==========================================
+ Coverage   53.96%   56.29%   +2.32%     
==========================================
  Files          41       41              
  Lines        1512     1597      +85     
==========================================
+ Hits          816      899      +83     
- Misses        696      698       +2
Impacted Files Coverage Δ
packages/graphql/lib/src/core/query_manager.dart 70.51% <70.58%> (+0.77%) :arrow_up:
packages/graphql/lib/src/core/_base_options.dart 90.00% <0.00%> (+2.50%) :arrow_up:
...es/graphql/lib/src/core/_query_write_handling.dart 73.07% <0.00%> (+7.69%) :arrow_up:
packages/graphql/lib/src/graphql_client.dart 82.85% <0.00%> (+8.57%) :arrow_up:
packages/graphql/lib/src/core/query_options.dart 55.50% <0.00%> (+16.21%) :arrow_up:
packages/graphql/lib/src/core/fetch_more.dart 35.29% <0.00%> (+35.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2306e12...2f1b98f. Read the comment docs.

vincenzopalazzo commented 2 years ago

looks like there is a import missing around error • The function 'initHiveForFlutter' isn't defined • test/widgets/query_test.dart:[11](https://github.com/zino-hofmann/graphql-flutter/runs/5229431340?check_suite_focus=true#step:6:11)5:11 • undefined_function

budde377 commented 2 years ago

@vincenzopalazzo, removed!

steebchen commented 2 years ago

Thanks, this is great to have 😁🙏