flutter 3.0 breaking changes

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.

https://zino-hofmann.github.io/graphql-flutter

MIT License

3.25k stars 620 forks source link

flutter 3.0 breaking changes #1131

Closed 94wogus-quantit closed 2 years ago

94wogus-quantit commented 2 years ago

in Flutter 3.0 Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

Stacktrace:

```shell ../../flutter/.pub-cache/hosted/pub.dartlang.org/graphql_flutter-5.1.0/lib/src/widgets/cache_provider.dart:45:20: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null. - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart'). WidgetsBinding.instance!.removeObserver(this); ```

94wogus-quantit commented 2 years ago

Currently using the fork repository.

graphql_flutter: git: url: https://github.com/Quantit-Github/graphql-flutter.git path: packages/graphql_flutter ref: f1ccb2d775826697fa0ab4f6d27d132f8a28f444 # commit hash

budde377 commented 2 years ago

Currently using the fork repository.

graphql_flutter:

git:

  url: https://github.com/Quantit-Github/graphql-flutter.git

  path: packages/graphql_flutter

  ref: f1ccb2d775826697fa0ab4f6d27d132f8a28f444 # commit hash

Please feel free to submit this as a pr

vincenzopalazzo commented 2 years ago

We will track this on https://github.com/zino-hofmann/graphql-flutter/issues/1134

It required some reasoning because if we support the new version we break the API for others that are not able to upgrade now to flutter 3.0

We will find a solution to make all happy! but for sure we will end up in someone that is migrating from flutter 1 to flutter 3 anyway.

Nzent commented 2 years ago

Have the same issue

vincenzopalazzo commented 2 years ago

please @Nzent see the changelog