search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.25k stars 620 forks source link

improve grapphql ws protocol docs #1180

Closed vincenzopalazzo closed 2 years ago

vincenzopalazzo commented 2 years ago

There is a collision name between javascript ecosystem and graphql protocols, and this makes the usage of the enum very difficult.

In addition, this is the first of a sequence of PR that improve graphql protocols handling

This should fix #1162

In addition, this introduces the new field in the commit header proposed in https://github.com/zino-hofmann/graphql-flutter/discussions/1179#discussioncomment-3102920 but this is still working in progress

codecov[bot] commented 2 years ago

Codecov Report

Merging #1180 (42595e9) into main (0d8a3d0) will decrease coverage by 0.03%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
- Coverage   59.72%   59.68%   -0.04%     
==========================================
  Files          41       41              
  Lines        1676     1677       +1     
==========================================
  Hits         1001     1001              
- Misses        675      676       +1
Impacted Files Coverage Δ
...l/lib/src/links/websocket_link/websocket_link.dart 0.00% <ø> (ø)
...lib/src/links/websocket_link/websocket_client.dart 81.77% <87.50%> (-0.41%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d8a3d0...42595e9. Read the comment docs.

vincenzopalazzo commented 2 years ago

Merging this for the moment, but I would like to keep this issue alive https://github.com/zino-hofmann/graphql-flutter/issues/1162

because there is somethings strange that happens when e we are working ws!