feat(graphql_common): add common package that contains utils functions

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.

https://zino-hofmann.github.io/graphql-flutter

MIT License

3.25k stars 620 forks source link

feat(graphql_common): add common package that contains utils functions #1207

Open vincenzopalazzo opened 2 years ago

vincenzopalazzo commented 2 years ago

We have a big lack in the library, we can not trace in case of a fancy problem, with this PR I'm proposing to put a generic interface + a Logger trace inside a separate package, and use it inside the client.

This will help us to safely make refactoring and trace the example that I proposed in other open PRs today!

[ ] Include the release process
[ ] make a sanity check of the Makefile

vincenzopalazzo commented 1 year ago

I think this is ready to get merged, but maybe after the official 5.1.2 release and we get it inside the 5.2.0-beta.1

What do you think? @budde377

vincenzopalazzo commented 1 year ago

The CI failure is unrelated we should publish our first common version but let do the more important stuff before

warning - pubspec.yaml:26:5 - Publishable packages can't have 'path' dependencies. Try adding a 'publish_to: none' entry to mark the package as not for publishing or remove the path dependency. - invalid_dependency

vincenzopalazzo commented 1 year ago

@budde377 this should be ready to be merged, and later I need to document it, but for now it is just a internal package so imho it is ready to go