search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.25k stars 620 forks source link

Fixes GraphQLWebSocketChannel missing implementation of ready #1281

Closed fennelhans closed 1 year ago

fennelhans commented 1 year ago

web_socket_channel was recently updated to add a ready property. This change makes flutter_graphql work again.

https://pub.dev/packages/web_socket_channel/changelog#230

Fixes https://github.com/zino-hofmann/graphql-flutter/issues/1282

vincenzopalazzo commented 1 year ago

missing some love in the commit messages, please read https://zino-hofmann.github.io/graphql-flutter/docs/dev/MAINTAINERS.html

fennelhans commented 1 year ago

I can update it, or you can change the single line for yourself. However, this issue is blocking me from committing my code to my repo.

vincenzopalazzo commented 1 year ago

Closing this because the CI is failing and the commit message is not accurate.

Ovverrided with https://github.com/zino-hofmann/graphql-flutter/pull/1283

you can change the single line for yourself

At least from my point of view, is more easily ignore the PR till it is ready to be merged, also because this is not a bug to trigger it you need to upgrade all the dependencies