search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.24k stars 612 forks source link

Update: added connected message #1309

Closed vytautas-pranskunas- closed 1 year ago

vytautas-pranskunas- commented 1 year ago

Fixes / Enhancements

Added message when websocket is connected

Docs

Added message when websocket is connected

Upteda by @vincenzopalazzo

Fixes https://github.com/zino-hofmann/graphql-flutter/issues/1308

vincenzopalazzo commented 1 year ago

please change the commit header to feat(graphql): print the connection status with ws

vincenzopalazzo commented 1 year ago

also the CI is complaing

8s
Run make ci_fmt_client
dart pub global run melos run client_analyze --no-select
melos run client_analyze
  └> melos exec -c [1](https://github.com/zino-hofmann/graphql-flutter/actions/runs/4425459030/jobs/7760880769#step:5:1) -- "dart format --set-exit-if-changed . && dart analyze . --fatal-infos"
     └> RUNNING

$ melos exec
  └> dart format --set-exit-if-changed . && dart analyze . --fatal-infos
     └> RUNNING (in 2 packages)

--------------------------------------------------------------------------------
example:
Formatted 3 files (0 changed) in 0.2[7](https://github.com/zino-hofmann/graphql-flutter/actions/runs/4425459030/jobs/7760880769#step:5:8) seconds.
Analyzing ....
No issues found!
example: SUCCESS
--------------------------------------------------------------------------------
graphql:
Formatted lib/src/links/websocket_link/websocket_client.dart
Formatted 54 files (1 changed) in 0.79 seconds.
--------------------------------------------------------------------------------

$ melos exec
  └> dart format --set-exit-if-changed . && dart analyze . --fatal-infos
     └> FAILED (in 1 packages)
        └> graphql (with exit code 1)

melos run client_analyze
  └> melos exec -c 1 -- "dart format --set-exit-if-changed . && dart analyze . --fatal-infos"
     └> FAILED
ScriptException: The script client_analyze failed to execute
make: *** [Makefile:[32](https://github.com/zino-hofmann/graphql-flutter/actions/runs/4425459030/jobs/7760880769#step:5:33): ci_fmt_client] Error 1
vytautas-pranskunas- commented 1 year ago

Changed

vincenzopalazzo commented 1 year ago

Need commit need to be removed https://github.com/zino-hofmann/graphql-flutter/pull/1309/commits/7757b8b17cfaf4cb83e856cde5238d841cf8d406

This required to squash your commit with the previous one

codecov[bot] commented 1 year ago

Codecov Report

Merging #1309 (84c1279) into main (4554a18) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head 84c1279 differs from pull request most recent head a9aefc4. Consider uploading reports for the commit a9aefc4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
+ Coverage   63.48%   63.50%   +0.02%     
==========================================
  Files          41       41              
  Lines        1687     1688       +1     
==========================================
+ Hits         1071     1072       +1     
  Misses        616      616
Impacted Files Coverage Δ
...lib/src/links/websocket_link/websocket_client.dart 80.09% <100.00%> (+0.09%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vytautas-pranskunas- commented 1 year ago

squashed

vytautas-pranskunas- commented 1 year ago

when it will be released?