zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.24k stars 612 forks source link

fix: added missing onSubscriptionResult argument #1312

Closed PhilippS93 closed 1 year ago

PhilippS93 commented 1 year ago

SubscriptionOnClient was missing the SubscriptionOnClient constructor param

Describe the purpose of the pull request.

vincenzopalazzo commented 1 year ago

thanks, could you add the scope in the commit header? like fix(graphql_flutter): added missing onSubscriptionResult argument

codecov[bot] commented 1 year ago

Codecov Report

Merging #1312 (0b67c14) into main (256133a) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head 0b67c14 differs from pull request most recent head 1b17d77. Consider uploading reports for the commit 1b17d77 to get more accurate results

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   63.50%   63.52%   +0.02%     
==========================================
  Files          41       41              
  Lines        1688     1689       +1     
==========================================
+ Hits         1072     1073       +1     
  Misses        616      616              
Impacted Files Coverage Δ
.../graphql_flutter/lib/src/widgets/subscription.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

PhilippS93 commented 1 year ago

alright, done!

vincenzopalazzo commented 1 year ago

ok, now the last thing is squash the commit in a single one, 3 commits for a single line of code change is to much sorry!

PhilippS93 commented 1 year ago

@vincenzopalazzo , when you accept the PR, you can select "Squash and Merge". This should solve the problem, doesn´t it?

vincenzopalazzo commented 1 year ago

@PhilippS93 does not work in this way, sorry!

PhilippS93 commented 1 year ago

No problem, I squashed the commits :)

vincenzopalazzo commented 1 year ago

Thanks!