search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.23k stars 613 forks source link

Pausable websocket reconnection #1365

Closed vytautas-pranskunas- closed 1 year ago

vytautas-pranskunas- commented 1 year ago

Introduced new feature which allows user to connect / disconnect manually. This is useful when for example user wants to stop autoreconnection on logout and resume on login.

Docs

codecov[bot] commented 1 year ago

Codecov Report

Merging #1365 (e7852c7) into main (6eaa2d2) will increase coverage by 0.51%. The diff coverage is 100.00%.

:exclamation: Current head e7852c7 differs from pull request most recent head bffa65a. Consider uploading reports for the commit bffa65a to get more accurate results

@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
+ Coverage   63.67%   64.19%   +0.51%     
==========================================
  Files          41       41              
  Lines        1696     1715      +19     
==========================================
+ Hits         1080     1101      +21     
+ Misses        616      614       -2
Impacted Files Coverage Δ
...lib/src/links/websocket_link/websocket_client.dart 82.60% <100.00%> (+2.51%) :arrow_up:
vincenzopalazzo commented 1 year ago

this is includind also the commit in this https://github.com/zino-hofmann/graphql-flutter/pull/1364 so the review of this make difficult

I will let you the fun of fighting with git

vytautas-pranskunas- commented 1 year ago

hi, i do not think so.. After you merge first PR second one should be more readable because those changes will be in main branch :) So lets start from the first one :)

On Mon, 24 Jul 2023 at 13:43, Vincenzo Palazzo @.***> wrote:

this is includind also the commit in this #1364 https://github.com/zino-hofmann/graphql-flutter/pull/1364 so the review of this make difficult

I will let you the fun of fighting with git

— Reply to this email directly, view it on GitHub https://github.com/zino-hofmann/graphql-flutter/pull/1365#issuecomment-1647750504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA54ZF2MAN2SQ7TTEB2AEWTXRZNU5ANCNFSM6AAAAAA2VNMH2Y . You are receiving this because you authored the thread.Message ID: @.***>

--

Pagarbiai,

Vytautas Pranskunas