search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.25k stars 622 forks source link

Send payload in PingMessage #1374

Closed Rochak69 closed 1 year ago

Rochak69 commented 1 year ago

Send payload in PingMessage

vincenzopalazzo commented 1 year ago

Thanks, can you drop the merge commit here https://github.com/zino-hofmann/graphql-flutter/pull/1374/commits/28754d90f8606360fbcd80809ba873018fca1ba9 and use the rebase?

thanks

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 96.66% and project coverage change: +0.51% :tada:

Comparison is base (6eaa2d2) 63.67% compared to head (fb560c0) 64.19%. Report is 8 commits behind head on main.

:exclamation: Current head fb560c0 differs from pull request most recent head 19d5c86. Consider uploading reports for the commit 19d5c86 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1374 +/- ## ========================================== + Coverage 63.67% 64.19% +0.51% ========================================== Files 41 41 Lines 1696 1715 +19 ========================================== + Hits 1080 1101 +21 + Misses 616 614 -2 ``` | [Files Changed](https://app.codecov.io/gh/zino-hofmann/graphql-flutter/pull/1374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zino-hofmann) | Coverage Δ | | |---|---|---| | [...lib/src/links/websocket\_link/websocket\_client.dart](https://app.codecov.io/gh/zino-hofmann/graphql-flutter/pull/1374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zino-hofmann#diff-cGFja2FnZXMvZ3JhcGhxbC9saWIvc3JjL2xpbmtzL3dlYnNvY2tldF9saW5rL3dlYnNvY2tldF9jbGllbnQuZGFydA==) | `82.60% <96.66%> (+2.51%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshisijan commented 1 year ago

Thank you @vincenzopalazzo for addressing this issue. When will the new release be published in pub.dev?