search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.25k stars 615 forks source link

fix: response extensions should be optional #1419

Closed kamilkarp closed 6 months ago

kamilkarp commented 6 months ago

1394 made SubscriptionData json always containing extensions. Now extensions in json are only present if response contained them.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.83%. Comparing base (ab3258c) to head (7e9c34b). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1419 +/- ## ========================================== + Coverage 64.63% 64.83% +0.20% ========================================== Files 41 41 Lines 1722 1732 +10 ========================================== + Hits 1113 1123 +10 Misses 609 609 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kamilkarp commented 6 months ago

@vincenzopalazzo Hi, I've noticed that after merging #1394, tests were failing due to extensions being always present. Sorry for that, here is the fix for that.

vincenzopalazzo commented 6 months ago

Hi @kamilkarp

No problem :) my fault that I did not catch it during review, but can you fix the formatting of the code?

kamilkarp commented 6 months ago

@vincenzopalazzo Analyzer fixed