feat: upgraded connectivity_plus package

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.

https://zino-hofmann.github.io/graphql-flutter

MIT License

3.25k stars 622 forks source link

feat: upgraded connectivity_plus package #1424

Closed Avinash-dhiraj closed 2 months ago

Avinash-dhiraj commented 7 months ago

As app store introduced mandatory privacy manifest files for some of packages being used in the application. connectivity_plus 6.0.2 is one of them and current version of connectivity_plus 6.0.2 has added support for privacy manifest but graphql_flutter still using connectivity_plus 5.0.0 which leads into compatibility issue. App store is very specific about the deadline of these as well which is 1st of may.;

upgraded connectivity_plus from 5.0.0 to 6.0.2

Please merge this on priority as this breaking changes is needed for all the flutter application which is using connectivity_plus 6.0.2 along with graphql_flutter

Fixes https://github.com/zino-hofmann/graphql-flutter/issues/1423#issuecomment-2052495874

vincenzopalazzo commented 7 months ago

looks like that needs a rebase, please ping me when the conflict are fixed

Avinash-dhiraj commented 7 months ago

looks like that needs a rebase, please ping me when the conflict are fixed

there is a conflict in pubspec file

<<<<<<< connectivity-plus-upgrade
  connectivity_plus: ^6.0.2
=======
  connectivity_plus: ^5.0.0
>>>>>>> main

<<<<<<< connectivity-plus-upgrade
  sdk: '>=3.3.0 <=4.0.0'
  flutter: ">=3.19.5"
=======
  sdk: '>=2.12.0 <4.0.0'
  flutter: ">=2.11.0"
>>>>>>> main

which can be resolved when someone merge it.

johnmartel commented 7 months ago

@vincenzopalazzo any chance of getting this merged and released quickly if I fork this PR and submit an updated version? This is creating an unnecessary roadblock for projects that use both graphql_flutter and connectivity_plus that want to upgrade their dependencies.

selawik commented 6 months ago

Any updates?

SachinCodeMatrix commented 6 months ago

@Avinash-dhiraj @vincenzopalazzo please check this

vincenzopalazzo commented 6 months ago

This is unresolved https://github.com/zino-hofmann/graphql-flutter/pull/1424#pullrequestreview-1999240159

I have nothing to check

vincenzopalazzo commented 2 months ago

Closing because looks like that there is already a fix https://github.com/zino-hofmann/graphql-flutter/issues/1423#issuecomment-2134515753

Please open a new PR with a good git history if the problem persit