search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.25k stars 622 forks source link

fix(graphql): add query timeout argument when create client. #1447

Closed ykuc7 closed 2 months ago

ykuc7 commented 4 months ago

Enhancements

souravdasslg commented 3 months ago

I needed this functionality, what is the release plan for this ? 🙏

ykuc7 commented 2 months ago

@vincenzopalazzo I resolved conflicts. Cloud you approve and merge PR?

vincenzopalazzo commented 2 months ago

Thanks @ykuc7 but could you remove the merge commit 1b52d198e98be4c183b626caaba91a3622b8a100 and just rebase on main

ykuc7 commented 2 months ago

@vincenzopalazzo Rebased and force pushed.

uri-ravzin commented 2 months ago

any chance we could have the argument as optional?

e.g. we prefer to let server handle the timeout and let the client library remain as it was before this change :)

vincenzopalazzo commented 2 months ago

@uri-ravzin PR are welcome if you add a good justification on why you need it optional

uri-ravzin commented 2 months ago

@uri-ravzin PR are welcome if you add a good justification on why you need it optional

We like to let the server handle the timeout. (as it was in older versions here as well)

short timeouts can lead to repeated requests, unexpected results, and actually increased load on the server, by users who just want to have their requests to complete.

Specifically in our product, we like the upgrades and are fast adopters to all beta releases, but currently seem to be stuck on 5.2.0-beta.7 due to this new introduced mandatory parameter.