Hi all, this line will break all requests that take longer than 5 seconds without any warning ...can this be a configuration value?

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.

https://zino-hofmann.github.io/graphql-flutter

MIT License

3.25k stars 622 forks source link

Hi all, this line will break all requests that take longer than 5 seconds without any warning ...can this be a configuration value? #1453

Open jpetey88 opened 3 months ago

jpetey88 commented 3 months ago

https://github.com/zino-hofmann/graphql-flutter/blob/59bb1d5bac4890c0025f38c385dce20a3b600c03/packages/graphql/lib/src/core/query_manager.dart#L260

leocape commented 1 month ago

+1 This 5 second limit is arbitrary and should be customisable at the client level (or better yet at the request level).

Our current use case that this is breaking - uploading documents frequently take > 5 seconds on slow mobile connections, and even though the upload succeeds, the response is an error (incorrectly) due to the client timeout to soon.

edit: I see a fix has been merged to main graphql-v5.2.0-beta.9, thanks!