firefox needs to use merge strategy as of version 47+

zinserjan / wdio-screenshot

A WebdriverIO plugin. Additional commands for taking screenshots with WebdriverIO.

MIT License

109 stars 43 forks source link

firefox needs to use merge strategy as of version 47+ #49

Closed wouterverweirder closed 7 years ago

wouterverweirder commented 7 years ago

Firefox no longer creates a full document screenshot and needs to use the merge strategy to generate a full document screenshot.

This pull request should fix #40

zinserjan commented 7 years ago

:thumbsup: Thanks for your PR.

My original idea was to support the fullpage screenshots of the older firefox versions, too. But I think it's not really worth it, cause it makes the code just more complicated...

wouterverweirder commented 7 years ago

Removed that version bump from my package.json & updated the commit :)

zinserjan commented 7 years ago

Cool, LGTM :)