search

zinserjan / wdio-visual-regression-service

Visual regression service for WebdriverIO.
MIT License
102 stars 39 forks source link

Webdriver.io Version 5 doesn't support 'wdio-visual-regression-service'. #90

Open GineaPig opened 5 years ago

GineaPig commented 5 years ago

Webdriver.io Version 5 doesn't support 'wdio-visual-regression-service'.

Environment (please complete the following information):

WebdriverIO version: 5.3.0 Mode: WDIO Testrunner If WDIO Testrunner, running sync/async: sync Browser name and version: [e.g. Chrome 71] Platform name and version: [e.g. Windows 10] Additional wdio packages used (if applicable): [ @wdio/spec reporter, @wdio/selenium-standalone service]

seanpoulter commented 5 years ago

This is a duplicate of #85. Should we coordinate the work to update it for v5?

ffwu commented 5 years ago

This is important to us. Highly appreciate if this can be ported soon.

aish-blr commented 5 years ago

After creating several test scripts using WebdriverIO, I am now looking for another end to end test tool only because Visual regression service compatibility is not there for V5. Visual testing is crucial for my project. So porting wdio-visual-regression-service to V5 at the earliest is highly appreciable.

anselmbradford commented 5 years ago

If it helps, there's a draft PR open to port wdio-cucumber-framework to V5. Perhaps that could help guide a port of this project too.

abjerstedt commented 5 years ago

To be fair, my work on the cucumber port won't help much with the visual regression service.

anselmbradford commented 5 years ago

@abjerstedt ah okay! I was thinking there was a migration pattern for upgrading these modules (admittedly I haven't looked at this closely).

PippoRaimondi commented 5 years ago

I need this tool, has anyone had a head start to make it compatible with wdio v5? if so please share the details so I don't waste time starting from scratch...

abjerstedt commented 5 years ago

@PippoRaimondi afaik - there has been no work towards this. Just create a draft/WIP pr while you work on the conversion.

seanpoulter commented 5 years ago

Let's pull in the folks who have participated in the duplicate issue as well for you @PippoRaimondi. Have any of you made progress on updating wdio-visual-regression-service to work with v5?

The other question, how would you like handle a PR @zinserjan?