zio / zio-ftp

A simple, idiomatic (S)FTP client for ZIO
https://zio.dev/zio-ftp
Apache License 2.0
29 stars 13 forks source link

feat: add `rename` command #232

Closed FlorianDoublet closed 2 years ago

regis-leray commented 2 years ago

@FlorianDoublet

Thanks for your contribution.

All the ftp method are exposed by using execute(), i was wondering why do we need to create an alias ?

We are exposing a method inside the FtpClient when we want to have custom logic. In this use case we are only creating an alias. Is there another reason ?

regis-leray commented 2 years ago

@FlorianDoublet your license approval is fixed. Build is failing you need to run sbt fmt

FlorianDoublet commented 2 years ago

@FlorianDoublet

Thanks for your contribution.

All the ftp method are exposed by using execute(), i was wondering why do we need to create an alias ?

We are exposing a method inside the FtpClient when we want to have custom logic. In this use case we are only creating an alias. Is there another reason ?

Thanks for your reply @regis-leray,

Indeed that's only for an alias purpose, but it was done for the 'rm' command too. It just could be handy to directly call .rename instead of passing by the execute method, don't you think ?

FlorianDoublet commented 2 years ago

@regis-leray the Install JDK step in the CI seems to be broken, so I can't see if anything else is wrong

regis-leray commented 2 years ago

looks like the build is broken, need to update the dependencies or move to github action. I created a ticket #235

regis-leray commented 2 years ago

@FlorianDoublet build is FIXED can you update your PR thank you