search

zio / zio-ftp

A simple, idiomatic (S)FTP client for ZIO
https://zio.dev/zio-ftp
Apache License 2.0
29 stars 13 forks source link

remove unneeded Scope requirement in FtpAccessors #353

Closed mberndt123 closed 1 year ago

mberndt123 commented 1 year ago

zio-ftp opens some streams to upload files, but it doesn't close them and thus leaks the Scope requirement. There's no reason to keep these streams open after uploading has completed, so let's just close them and remove the Scope requirement.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

regis-leray commented 1 year ago

Thanks again for your MR ! and catching to close the inputstream :)

mberndt123 commented 1 year ago

Thanks for the review, @regis-leray. That file you asked about is auto-generated by sbt docs/generateGithubWorkflow, which I needed to run to make CI pass. Is there anything else, or can this be merged now?

regis-leray commented 1 year ago

@mberndt123 you can merge

mberndt123 commented 1 year ago

@regis-leray,

I can't merge that, I don't have the required permissions. Can you do that for me?