search

zio / zio-http

A next-generation Scala framework for building scalable, correct, and efficient HTTP clients and servers
https://zio.dev/zio-http
Apache License 2.0
800 stars 403 forks source link

Test latest zio snapshot #3118

Closed kyri-petrou closed 1 month ago

kyri-petrou commented 2 months ago

Testing whether the ZPool related flakiness is gone with the latest ZIO snapshot

jdegoes commented 1 month ago

@kyri-petrou Please re-open if you need to do further testing! I take it from the failure, ZPool has more work to do??

kyri-petrou commented 1 month ago

@jdegoes the issue is with a badly written test which provides the Client layer and then closes the request Scope. Previously ZPool would leak the connection pool resources so the test would succeed, but with the new implementation the connections are correctly closed when the Client.default finalizers are run so the test is failing.

I'll open a PR to fix the test