zio / zio-http

A next-generation Scala framework for building scalable, correct, and efficient HTTP clients and servers
https://zio.dev/zio-http
Apache License 2.0
800 stars 403 forks source link

Issue 3165: Fix Forwarded Header rendering #3166

Closed scottweaver closed 1 month ago

scottweaver commented 1 month ago

This set of change address the issue described in https://github.com/zio/zio-http/issues/3165.

For instance the header, 'Header.Forwarded(forValues = List("127.0.0.1"))', previously rendered incorrectly as 'None; for=127.0.0.1; None; None'.

It now properly renders as 'for=127.0.0.1;'.

It includes an additional test spec that uses a property check to verify all permutations optional directives.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.32%. Comparing base (f164c90) to head (67b857f). Report is 12 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3166 +/- ## ========================================== + Coverage 65.09% 65.32% +0.23% ========================================== Files 161 161 Lines 10551 10570 +19 Branches 2024 2013 -11 ========================================== + Hits 6868 6905 +37 + Misses 3683 3665 -18 ``` | [Flag](https://app.codecov.io/gh/zio/zio-http/pull/3166/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/zio/zio-http/pull/3166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `65.32% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.