search

zio / zio-http

A next-generation Scala framework for building scalable, correct, and efficient HTTP clients and servers
https://zio.dev/zio-http
Apache License 2.0
800 stars 403 forks source link

Special case encode optional for HttpCodec.Content (#3144) #3167

Closed 987Nabil closed 1 month ago

987Nabil commented 1 month ago

While this is a real bug fix, the preferred way should be HttpCodec.content[Option[MyType]]

fixes #3144 /claim #3144

987Nabil commented 1 month ago

Is this MIMA issue a real issue? 🤔

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (f164c90) to head (48a1c62). Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/scala/zio/http/codec/HttpContentCodec.scala 36.36% 7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3167 +/- ## ========================================== + Coverage 65.09% 65.20% +0.11% ========================================== Files 161 161 Lines 10551 10585 +34 Branches 2024 2044 +20 ========================================== + Hits 6868 6902 +34 Misses 3683 3683 ``` | [Flag](https://app.codecov.io/gh/zio/zio-http/pull/3167/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/zio/zio-http/pull/3167/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `65.20% <63.15%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.