zio / zio-jdbc

A small, idiomatic ZIO interface to JDBC.
Apache License 2.0
82 stars 64 forks source link

Fix `java.time.Instant` tests #182

Closed guizmaii closed 1 year ago

guizmaii commented 1 year ago

Dumb copy/paste mistake 😭

This comment made me doubt my code: https://github.com/pgjdbc/pgjdbc/issues/1325#issuecomment-439467466 Especially this line:

As you can see the time java.sql.Timestamp -> java.time.Instant conversion depends on the JVM default time zone.

because it was what I was experiencing and why I had to set the JVM default timezone before starting the tests, which was, as @987Nabil was pointing out, weird.

Thanks @987Nabil for your review 🙂