zio / zio-metrics-connectors

Monitoring, Metrics and Diagnostics for ZIO
https://zio.dev/zio-metrics-connectors
Apache License 2.0
30 stars 24 forks source link

Micrometer #20

Closed Fristi closed 1 year ago

Fristi commented 1 year ago

It seems micrometer is the SLF4j variant for metrics

Lot's of integrations: https://micrometer.io/docs

Thoughts on integrating this?

Gives a lot of integrations next to: statsd, prometheus and newrelic which we already have "native" implementations for.

atooni commented 1 year ago

Seems to be worth looking at. Ideally we would create a mapping of the metric state we have inside ZIO core to the Micrometer API. Its certainly worth to look at, perhaps in the next Hackathon.

At the moment we are working on integrating the metrics and other information coming from the ZIO runtime into ZIO Insight to give ZIO developers a one stop shop for gaining information and Insight into a running ZIO application.

vagroz commented 1 year ago

What about kafka metrics? They can be collected via Micrometer meter registry. How do I publish them using PrometheusPublisher?

UPD: It would be nice to publish ZIO metrics into the Micrometer's PrometheusMeterRegistry, which can already collect metrics from many libraries, including kafka metrics.

vagroz commented 1 year ago

Hello. Why is this issue closed?

atooni commented 1 year ago

AFAICS this was closed by the original requestor .

vagroz commented 1 year ago

Could this be re-opened? Or may I open a new one?

atooni commented 1 year ago

Reopened

calvinlfer commented 1 year ago

this is completed with @Grryum's work 😸

Fristi commented 1 year ago

Nice! Closing then :)