Add min / max metrics from Summary and Histogram to Prometheus connector

zio / zio-metrics-connectors

Monitoring, Metrics and Diagnostics for ZIO

https://zio.dev/zio-metrics-connectors

Apache License 2.0

30 stars 24 forks source link

Closed vladimirkl closed 1 year ago

vladimirkl commented 1 year ago

This PR does the following:

Adds missing min / max metrics from Summary and Histogram to Prometheus connector.
Fixes double space after bucket label - this rendering is not standard and breaks some scrapers.
Adds basic test suite for PrometheusEncoder

vladimirkl commented 1 year ago

@atooni Could you review this PR? Seems that approve from @guizmaii is not enough to unblock merging

guizmaii commented 1 year ago

Seems that approve from @guizmaii is not enough to unblock merging

Yeah, my approval has no real value here. I just read the code and it seems ok to me, but I don't know the code of this project

atooni commented 1 year ago

Approved - thanks for the enhancement !

vladimirkl commented 1 year ago

@atooni fixed test compilation under Scala 2.12 - please approve again to run the workflow

vladimirkl commented 1 year ago

@atooni All checks are green, can you merge it?