Closed calvinlfer closed 1 year ago
Nice changes @calvinlfer! Thank you! I can merge this once you fixed the merge conflicts.
Would you like to update the documentation in this PR too? I am thinking that we should mention here the additional artifacts have to be specified in the dependencies.
Nice changes @calvinlfer! Thank you! I can merge this once you fixed the merge conflicts.
Would you like to update the documentation in this PR too? I am thinking that we should mention here the additional artifacts have to be specified in the dependencies.
Hey @petoalbert, afaik you don't need to include any additional dependencies for prometheus, its fully self-contained since we build the strings within the library. It's on the user to expose the strings for scraping via a web endpoint. Is that the documentation you are after?
I've pulled all examples into the sample project module
@calvinlfer I meant that the documentation for the prometheus client should mention that the first step to use the module should be to specify dev.zio:zio-metrics-connectors-prometheus
as a dependency, and the same for every other metric client. Currently the only artefact mentioned in the documentation is here.
I am happy to merge this now and create an issue to track the documentation. 🙂
Closes https://github.com/zio/zio-metrics-connectors/issues/2 Closes https://github.com/zio/zio-metrics-connectors/issues/3